feat(node-v21): added support for node v21 #947
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aryamohanan
force-pushed
the
feat/nodev21
branch
4 times, most recently
from
f5fd53c
to
cf0d664
Compare
kirrg001
force-pushed
the
v3
branch
3 times, most recently
from
bf0a943
to
c6cc27c
Compare
aryamohanan
force-pushed
the
feat/nodev21
branch
4 times, most recently
from
9340afb
to
69857ff
Compare
aryamohanan
commented
Dec 4, 2023
aryamohanan
force-pushed
the
feat/nodev21
branch
from
03578f9
to
e1264e3
Compare
aryamohanan
force-pushed
the
feat/nodev21
branch
from
baf8ca2
to
0293099
Compare
kirrg001
reviewed
Dec 4, 2023
|
issue:
I think this needs to be removed for now or? |
aryamohanan
force-pushed
the
feat/nodev21
branch
2 times, most recently
from
e8031dd
to
098fe4d
Compare
kirrg001
reviewed
Dec 5, 2023
aryamohanan
force-pushed
the
feat/nodev21
branch
2 times, most recently
from
aea65f1
to
914361c
Compare
The shared-metrics add-ons had accidentally been build for the CPU architecture arm64 instead of x86_64.
Also, use the Docker image node:${targetNodeVersion}
instead of node:${targetNodeVersion}-buster for building the autoprofile
binaries. Specifying a specific Debian distribution has a tiny
maintenance disadvantage, as node images are not always provided for all
Debian distributions. There is no node:21.2.0-buster, for example, as
Debian Buster is simply too old by now.
aryamohanan
force-pushed
the
feat/nodev21
branch
from
914361c
to
a13830c
Compare
kirrg001
reviewed
Dec 6, 2023
aryamohanan
force-pushed
the
feat/nodev21
branch
2 times, most recently
from
2b61972
to
e6e20b1
Compare
kirrg001
approved these changes
Dec 8, 2023
kirrg001
pushed a commit
that referenced
this pull request
Dec 11, 2023
kirrg001
pushed a commit
that referenced
this pull request
Dec 11, 2023
kirrg001
reviewed
Apr 30, 2024
|
|
||
| if (!supportedVersion(process.versions.node) || !process.env.GCP_PROJECT) { | ||
| if (!supportedVersion(process.versions.node) || !process.env.GCP_PROJECT || | ||
| semver.gte(process.versions.node, '21.2.0')) { |
There was a problem hiding this comment.
@instana/eng-nodejs I have created a ticket for this. The bug is resolved. Good first task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problems:
Node v21 is not working with ESM nodejs/loaders#147
Open issue for Node v21 for google googleapis/nodejs-storage#2368