Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: add ESM build to icon fonts and refactor the icon docs page #1737

Merged
merged 1 commit into from
Oct 18, 2024
Merged

chore: add ESM build to icon fonts and refactor the icon docs page #1737

merged 1 commit into from
Oct 18, 2024

Conversation

balzss
Copy link
Contributor

@balzss balzss commented Oct 15, 2024

  • add esm option to build icon fonts and keep the current for compatibility
  • refactor docs to not depend on the ui-icons commonjs build and make it overall simpler

test plan:

  • check the icon docs (for completeness and performance too)

@balzss balzss self-assigned this Oct 15, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 15, 2024 •
edited
Loading

PR Preview Action v1.4.8
Preview removed because the pull request was closed.
2024-10-18 13:21 UTC

matyasf
matyasf requested changes Oct 16, 2024
View reviewed changes
Copy link
Collaborator

@matyasf matyasf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, much much simpler code than before. Please add a comment to our icons page about the deprecations and the ui-icons-build code

packages/ui-scripts/lib/icons/generate-icon-fonts.js Show resolved Hide resolved
@balzss balzss force-pushed the chore/icon-build-esm branch 4 times, most recently from 5da3f05 to b63049b Compare October 17, 2024 14:34
@balzss balzss requested a review from matyasf October 17, 2024 14:56
@balzss balzss mentioned this pull request Oct 17, 2024
Merged
joyenjoyer
joyenjoyer requested changes Oct 18, 2024
View reviewed changes
Copy link
Contributor

@joyenjoyer joyenjoyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work.

@balzss balzss merged commit 8634e63 into master Oct 18, 2024
11 checks passed
@balzss balzss deleted the chore/icon-build-esm branch October 18, 2024 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matyasf matyasf matyasf approved these changes

@joyenjoyer joyenjoyer joyenjoyer approved these changes

Assignees

@balzss balzss

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@balzss @matyasf @joyenjoyer