Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add ESM build to icon fonts and refactor the icon docs page #1737

Merged
merged 1 commit into from
Oct 18, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion .github/workflows/deploy.yml
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,11 @@ jobs:
deploy-docs:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v3
- uses: actions/checkout@v4
- name: Install Node 22
uses: actions/setup-node@v4
with:
node-version: '22'
- run: npm ci && npm run bootstrap
- name: Set build directory and deployment path based on branch
id: set-build-dir
Expand Down
4 changes: 4 additions & 0 deletions .github/workflows/preview.yml
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,10 @@ jobs:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
- name: Install Node 22
uses: actions/setup-node@v4
with:
node-version: '22'
- name: Npm install and bootstrap
run: npm ci && npm run bootstrap
if: github.event.action != 'closed' # don't run install and bootstrap unnecessarily when pr is closed
Expand Down
2 changes: 1 addition & 1 deletion docs/patterns/UsingIcons.md
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ type: example

### Line vs Solid

The default choice for iconography is the `Line` version. However, when an icon appears on a dark or colored background, the `Solid` version should be used.
The default choice for icons are the `Line` version. However, when an icon appears on a dark or colored background, the `Solid` version should be used.

```js
---
Expand Down
Loading
Loading