-
Notifications
You must be signed in to change notification settings - Fork 460
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Specify black version in pre-commit config #970
Conversation
We will have to specify black version 20.8b1 everywhere in the documentation. Basically the contribution section as well as the requirements.txt file. |
Updating requirements.txt content from black to git+git://github.com/psf/black works as well. |
Yeah, this is a temporary solution at best. I'm not sure I like it. Did you want to take a stab at something more comprehensive? I can close this one and leave you to it if you'd like! I think what we want is to ensure we're getting the latest from |
(I can just diable my conflicting pre-commit for today.) |
@terriko @imsahil007
That's because at that point in time you had They just released a new version yesterday and
As I noted above:
Now how to sync But if we want to sync Also can add a new scheduled workflow that will check for updated hooks in Of course it also applies to isort. |
Well, looks like they are committed to updating it more often now.
It's fine to use it in CI but in Maybe use pre-commit.ci? It will autoupdate |
This isn't a perfect solution to #909, because I think I should probably change the github action to match, but it should resolve issues for folk using the pre-commit hook and getting conflicts with what's in Github Actions for now.