-
Notifications
You must be signed in to change notification settings - Fork 460
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update instructions to install latest version of black #973
Conversation
Should we close #909 as well? |
Hm, I thought the problem was backwards to this -- it seemed like I had 20.8b1 (latest from pypi) installed, but it seemed like CI was using something else. I'd like to switch our CI (and pre-commit) use latest release (or I guess in this case latest beta release, but it's what's tagged as latest in pypi) |
Installing black from GitHub instead of PyPI is a temporary solution for this. But the user might need to update it every then and now. We can do 2 things right now:
|
What I really want is for pre-commit to use the latest tagged release. I think this is likely closer to option 2, and in fact our current pre-commit specifies
At a guess, the problem is that pre-commit doesn't see something with the version |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Whoops, this was hit on the wrong PR, sorry.
Revisiting this: So if CI is using 20.8b1, changing our docs to recommend anything other than that is going to lead to frustration. I guess I'm going to go with the solution in #970 for now, and we'll see if it changes frequently enough to be annoying. I'd still really like a solution that told pre-commit to use the latest release instead of a specific tag, but as best I can tell it doesn't support that at this time. |
We can close #970 now.
This will ensure that user install the latest version from black Github repo