Skip to content
This repository has been archived by the owner on Aug 5, 2022. It is now read-only.

[arduino] An obvious increase of ROM cause building failure #1888

Closed
qiaojingx opened this issue Jun 12, 2018 · 1 comment
Closed

[arduino] An obvious increase of ROM cause building failure #1888

qiaojingx opened this issue Jun 12, 2018 · 1 comment

Comments

@qiaojingx
Copy link

Description

This is a regression issue. ROM samples increase obviously from last commit on arduino 101, some test case fail to build due to ROM problem.

Test Code

test-ocfserver.js;
th02-ocf.js;
test-tcp6-server.js;

Steps to Reproduction

  1. make JS=tests/test-ocfserver.js ROM=256
  2. Increase ROM and repeat step 1.

Actual Result

Increase ROM from 256-290, build failed due to ' ROM ' overflow.
screenshot from 2018-06-12 17-02-24

Increase ROM to 292, build failed due to `FLASH' overflow:
screenshot from 2018-06-12 17-02-24

Expected Result

Build each test case successfully.

Test Builds

Branch Commit Id Target Device Test Date Result
master f90d9d1 arduino 101 May 24, 2018 Pass
master 2b033e1 arduino 101 Jun 12, 2018 Fail

Additional Information

ROM=256 is not suitable for most of samples and tests.
@qiaojingx qiaojingx changed the title [arduino] Obviously increase of ROM cause building failure [arduino] An obvious increase of ROM cause building failure Jun 12, 2018
jimmy-huang added a commit to jimmy-huang/zephyr.js that referenced this issue Jun 12, 2018
@jimmy-huang
[snapshot] Fixed incorrect snapshot size
2f0c864 
JerryScript updated the generate_snapshot API to return
a jerry_value instead of the size, so if you directly
use the size returned, it will be incorrect.

Fixes intel#1888

Signed-off-by: Jimmy Huang <[email protected]>
@jimmy-huang jimmy-huang mentioned this issue Jun 12, 2018
Merged
jimmy-huang added a commit to jimmy-huang/zephyr.js that referenced this issue Jun 14, 2018
@jimmy-huang
[snapshot] Fixed incorrect snapshot size
76cac6e 
JerryScript updated the generate_snapshot API to return
a jerry_value instead of the size, so if you directly
use the size returned, it will be incorrect.

Also fixes a buid error with dynamic mode.

Fixes intel#1888, intel#1890

Signed-off-by: Jimmy Huang <[email protected]>
jimmy-huang added a commit to jimmy-huang/zephyr.js that referenced this issue Jun 14, 2018
@jimmy-huang
[snapshot] Fixed incorrect snapshot size
9fe0749 
JerryScript updated the generate_snapshot API to return
a jerry_value instead of the size, so if you directly
use the size returned, it will be incorrect and cause the
final ROM size to not fit the board.

Also fixes a buid error with dynamic mode.

Fixes intel#1887 intel#1888, intel#1890

Signed-off-by: Jimmy Huang <[email protected]>
@qiaojingx
Copy link
Author

Verified with commit 2b033e1 + #1889. This issue is fixed.
This issue will be closed after patch #1889 merged.

grgustaf pushed a commit that referenced this issue Jul 9, 2018
@grgustaf
[snapshot] Fixed incorrect snapshot size (#1889)
3a701fb 
JerryScript updated the generate_snapshot API to return
a jerry_value instead of the size, so if you directly
use the size returned, it will be incorrect and cause the
final ROM size to not fit the board.

Also fixes a buid error with dynamic mode.

Fixes #1887 #1888, #1890

Signed-off-by: Jimmy Huang <[email protected]>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@qiaojingx