Skip to content
This repository has been archived by the owner on Aug 5, 2022. It is now read-only.

[dynamic] make dynamic failed #1890

Open
qiaojingx opened this issue Jun 13, 2018 · 1 comment
Open

[dynamic] make dynamic failed #1890

qiaojingx opened this issue Jun 13, 2018 · 1 comment

Comments

@qiaojingx
Copy link

Description

This is a regression issue. Build dynamic failed.

Test Code

/modules/Assert.js;
/tests/test-timers.js;

Simple test.js:
runJS('timer.js');

Steps to Reproduction

  1. Copy /modules/Assert.js to a101 board as assert.js
  2. Copy /tests/test-timers.js to a101 board as timer.js
  3. Build simple test.js and flash it to a101 board.
    make dynamic JS=samples/test.js ROM=256

Actual Result

Build failed:
selection_002

Expected Result

Build dynamic successfully.

Test Builds

Branch Commit Id Target Device Test Date Result
master f90d9d1 arduino 101 Jun 12, 2018 Pass
master 2b033e1 arduino 101 Jun 12, 2018 Fail

Additional Information
@qiaojingx qiaojingx changed the title [dynamic] make dynamic target failed [dynamic] make dynamic failed Jun 13, 2018
jimmy-huang added a commit to jimmy-huang/zephyr.js that referenced this issue Jun 14, 2018
@jimmy-huang
[snapshot] Fixed incorrect snapshot size
76cac6e 
JerryScript updated the generate_snapshot API to return
a jerry_value instead of the size, so if you directly
use the size returned, it will be incorrect.

Also fixes a buid error with dynamic mode.

Fixes intel#1888, intel#1890

Signed-off-by: Jimmy Huang <[email protected]>
@jimmy-huang jimmy-huang mentioned this issue Jun 14, 2018
Merged
jimmy-huang added a commit to jimmy-huang/zephyr.js that referenced this issue Jun 14, 2018
@jimmy-huang
[snapshot] Fixed incorrect snapshot size
9fe0749 
JerryScript updated the generate_snapshot API to return
a jerry_value instead of the size, so if you directly
use the size returned, it will be incorrect and cause the
final ROM size to not fit the board.

Also fixes a buid error with dynamic mode.

Fixes intel#1887 intel#1888, intel#1890

Signed-off-by: Jimmy Huang <[email protected]>
@qiaojingx
Copy link
Author

Verified with commit 2b033e1 + #1889. This issue is fixed.
This issue will be closed after patch #1889 merged.

grgustaf pushed a commit that referenced this issue Jul 9, 2018
@grgustaf
[snapshot] Fixed incorrect snapshot size (#1889)
3a701fb 
JerryScript updated the generate_snapshot API to return
a jerry_value instead of the size, so if you directly
use the size returned, it will be incorrect and cause the
final ROM size to not fit the board.

Also fixes a buid error with dynamic mode.

Fixes #1887 #1888, #1890

Signed-off-by: Jimmy Huang <[email protected]>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@qiaojingx