2852/refactor/replace urllib with requests in utils httpserver #4407
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sabreen-Parveen
pushed a commit
to Sabreen-Parveen/openlibrary
that referenced
this pull request
Feb 5, 2021
…netarchive#4407) * Replaced urllib with requests * Delete openlibrary.utils.httpserver because it is no longer used. * Upgrade to Python 3.9.1 * Upgrade to Python 3.9.1 Co-authored-by: Christian Clauss <[email protected]>
Sabreen-Parveen
pushed a commit
to Sabreen-Parveen/openlibrary
that referenced
this pull request
Feb 5, 2021
…netarchive#4407) * Replaced urllib with requests * Delete openlibrary.utils.httpserver because it is no longer used. * Upgrade to Python 3.9.1 * Upgrade to Python 3.9.1 Co-authored-by: Christian Clauss <[email protected]>
Sabreen-Parveen
pushed a commit
to Sabreen-Parveen/openlibrary
that referenced
this pull request
Feb 5, 2021
…netarchive#4407) * Replaced urllib with requests * Delete openlibrary.utils.httpserver because it is no longer used. * Upgrade to Python 3.9.1 * Upgrade to Python 3.9.1 Co-authored-by: Christian Clauss <[email protected]>
Sabreen-Parveen
pushed a commit
to Sabreen-Parveen/openlibrary
that referenced
this pull request
Feb 5, 2021
…netarchive#4407) * Replaced urllib with requests * Delete openlibrary.utils.httpserver because it is no longer used. * Upgrade to Python 3.9.1 * Upgrade to Python 3.9.1 Co-authored-by: Christian Clauss <[email protected]>
Sabreen-Parveen
pushed a commit
to Sabreen-Parveen/openlibrary
that referenced
this pull request
Feb 5, 2021
…netarchive#4407) * Replaced urllib with requests * Delete openlibrary.utils.httpserver because it is no longer used. * Upgrade to Python 3.9.1 * Upgrade to Python 3.9.1 Co-authored-by: Christian Clauss <[email protected]>
Sabreen-Parveen
pushed a commit
to Sabreen-Parveen/openlibrary
that referenced
this pull request
Feb 15, 2021
…netarchive#4407) * Replaced urllib with requests * Delete openlibrary.utils.httpserver because it is no longer used. * Upgrade to Python 3.9.1 * Upgrade to Python 3.9.1 Co-authored-by: Christian Clauss <[email protected]>
mekarpeles
added
python
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #2852
Refactor to remove
openlibrary/utils/httpserver.pybecause it is no longer used.Technical
There was a doctest in there, which was being ignored, and did not work either before or after refactoring. I could not find anything in the repo which references the file, so I think this can be deleted. I think it was replaced with
web.httpservera few years ago.Testing
Unit tests run.
Screenshot
N/A
Stakeholders
@cclauss