Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2852/refactor/replace urllib with requests in utils httpserver #4407

Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .python-version
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
3.8.6
3.9.0
3.9.1
2.7.6
8 changes: 4 additions & 4 deletions docker/Dockerfile.olbase
Original file line number Diff line number Diff line change
Expand Up @@ -44,15 +44,15 @@ ENV PATH $PYENV_ROOT/shims:$PYENV_ROOT/bin:$PATH

RUN pyenv update && pyenv install 2.7.6
RUN pyenv update && pyenv install 3.8.6
RUN pyenv update && pyenv install 3.9.0
RUN pyenv global 3.8.6 3.9.0 2.7.6
RUN pyenv update && pyenv install 3.9.1
RUN pyenv global 3.8.6 3.9.1 2.7.6
RUN pyenv rehash

# Update Python 2's pip to match production (Jan 2020)
RUN python2 -m pip install --upgrade --disable-pip-version-check pip==19.3.1
# Install wheel before other requirements to reduce Docker build time.
RUN python3.8 -m pip install --upgrade pip wheel==0.35.1
RUN python3.9 -m pip install --upgrade pip wheel==0.35.1
RUN python3.8 -m pip install --upgrade pip wheel
RUN python3.9 -m pip install --upgrade pip wheel

USER root
# Add pyenv to root's bashrc as well
Expand Down
87 changes: 0 additions & 87 deletions openlibrary/utils/httpserver.py

This file was deleted.

1 change: 0 additions & 1 deletion scripts/run_doctests.sh
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,6 @@ pytest --doctest-modules \
--ignore=openlibrary/solr/update_work.py \
--ignore=openlibrary/tests/catalog/test_get_ia.py \
--ignore=openlibrary/utils/form.py \
--ignore=openlibrary/utils/httpserver.py \
--ignore=openlibrary/utils/schema.py \
--ignore=openlibrary/utils/solr.py \
--ignore=scripts \
Expand Down