-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: change OCI punchout URL to ICM Pipeline #1702
Open
fgiesske-intershop
wants to merge
2
commits into
develop
Choose a base branch
from
feature/change-oci-punchout-url-to-pipeline
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
feat: change OCI punchout URL to ICM Pipeline #1702
fgiesske-intershop
wants to merge
2
commits into
develop
from
feature/change-oci-punchout-url-to-pipeline
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fgiesske-intershop
added
feature
New feature or request
refactoring
Refactoring of current code
labels
Jul 25, 2024
✅ Successfully linked to Azure Boards work item(s): |
skoch-intershop
approved these changes
Jul 26, 2024
skoch-intershop
requested changes
Jul 26, 2024
src/app/core/store/core/configuration/configuration.selectors.ts
Outdated
Show resolved
Hide resolved
shauke
force-pushed
the
feature/change-oci-punchout-url-to-pipeline
branch
from
August 21, 2024 11:44
d7919bb
to
b2623fb
Compare
shauke
previously approved these changes
Aug 21, 2024
shauke
pushed a commit
that referenced
this pull request
Aug 21, 2024
* ICM pipeline can handle OCI punchout functions `BACKGROUND_SEARCH` and `VALIDATE` better * ICM redirects to the PWA only for catalog browsing and the detail function + needs ICM 12.2.0, 11.11.1 or 7.10.41.3 * ICM pipeline `ViewOCICatalogPWA-Start` is used for the OCI punchout URL * added migration note and deprecation notes for similar PWA functionality
shauke
force-pushed
the
feature/change-oci-punchout-url-to-pipeline
branch
from
August 21, 2024 12:13
b2623fb
to
708872e
Compare
shauke
changed the title
feat: change oci punchout url to pipeline endpoint
feat: change OCI punchout URL to ICM Pipeline
Aug 21, 2024
shauke
approved these changes
Aug 21, 2024
…peline URL references * provide configuration option similar to `icmServer` or `icmServerStatic``
* ICM pipeline can handle OCI punchout functions `BACKGROUND_SEARCH` and `VALIDATE` better * ICM redirects to the PWA only for catalog browsing and the detail function + needs ICM 12.2.0, 11.11.1 or 7.10.41.3 * ICM pipeline `ViewOCICatalogPWA-Start` is used for the OCI punchout URL * added migration note and deprecation notes for similar PWA functionality
shauke
force-pushed
the
feature/change-oci-punchout-url-to-pipeline
branch
from
August 23, 2024 16:09
708872e
to
6fa90dc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
feature
New feature or request
refactoring
Refactoring of current code
wait
Waiting for something (e.g. new ICM release)
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Type
[x] Feature
What Is the Current Behavior?
In B2B my account under the Punchout > OCI tab there is a Punchout configuration URL pointing to the PWA, this needs to be changed to the ICM pipeline ViewOCICatalogPWA-Start.
What Is the New Behavior?
The OCI Punchout URL has been changed to be a pipeline endpoint.
A new URL configuration selector has been added to generate a pipeline URL.
Does this PR Introduce a Breaking Change?
[x] No
Other Information
The new OCI Punchout URL is available as of ICM versions 7.10.41.3, 11.11.1 or 12.2.0.
We need to wait with merging at least until ICM 12.2.0 is released.
AB#98435