-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(button): add components playgrounds #2530
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The playground examples look great to me 👍
Thoughts on eliminating the table sections and moving that information into the comment blocks in Ionic Framework, to be autogenerated as part of the "Properties" section?
This could help us prevent docs from becoming stale, since when introducing or removing property values in a feature, hopefully we would catch that the JSDoc comment was not updated with the new context.
Edit:
This also would help improve Intellisense Dx.
@sean-perkins That's a good idea. I will look into adding that into the framework before removing from here & merging. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM aside from a couple nitpicks and moving the info in those tables to the generated docs 👍
Co-authored-by: Amanda Johnston <[email protected]>
I removed the tables from the docs here and that info has been added to the properties themselves here: ionic-team/ionic-framework#25940 |
Question: should we remove the tables / descriptions under some of the headings?
I left them there to keep the additional information, but maybe we should either have them or not?