fix(breadcrumb): support routerLink on breadcrumb #24509
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
package: core
averyjohnston
approved these changes
Jan 5, 2022
liamdebeasi
reviewed
Jan 5, 2022
There was a problem hiding this comment.
Let's discuss the implications of this prior to merging. There's already another issue related to this: #23553
We should discuss the intended scope of routing integration for the breadcrumbs so we can set expectations accordingly.
liamdebeasi
approved these changes
Jan 10, 2022
There was a problem hiding this comment.
I think adding routerLink support to breadcrumb makes sense as it is already supported in Angular and Vue. We can discuss the scope of routing support in #23553. Great job!
This was referenced Feb 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request checklist
Please check if your PR fulfills the following requirements:
npm run build) was run locally and any changes were pushednpm run lint) has passed locally and any fixes were made for failuresPull request type
Please check the type of change your PR introduces:
What is the current behavior?
ion-breadcrumbdoes not support the routable behaviors of similar components (i.e.routerLink) andhrefcauses a full refresh.Issue Number: Resolves #24493
What is the new behavior?
ion-breadcrumbis treated as a routable component for React and now supportsrouterLink.Does this introduce a breaking change?
Other information