Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: ion-nav transitions are broken in react #25688

Closed
4 of 7 tasks
sean-perkins opened this issue Jul 27, 2022 · 5 comments · Fixed by #25689
Closed
4 of 7 tasks

bug: ion-nav transitions are broken in react #25688

sean-perkins opened this issue Jul 27, 2022 · 5 comments · Fixed by #25689
Labels
package: react @ionic/react package type: bug a confirmed bug report

Comments

@sean-perkins
Copy link
Contributor

Prerequisites

Ionic Framework Version

  • v4.x
  • v5.x
  • v6.x
  • Nightly

Current Behavior

Starting in 6.1.15, IonNav page transitions are incorrect.

The changes to support custom sized dialogs, introduced a change to the global stylesheet that is being applied in scenarios where IonNav is used within IonModal.

Problematic styles:

ion-modal .ion-page {
  position: relative;

  contain: layout style;

  height: 100%;
}

Expected Behavior

IonNav transitions should be consistent within a modal or outside of a modal.

Steps to Reproduce

  1. Clone: https://github.com/milang/ionic-simplevitejs
  2. Checkout branch: recursivemodalnav
  3. npm install
  4. npm run dev
  5. Click "Open Modal"
  6. Click "Push"
  7. Observe the incorrect transition between views

Code Reproduction URL

https://github.com/milang/ionic-simplevitejs

Ionic Info

6.1.15+

Additional Information

Related to: #25677 (caused by the same change, but are effected differently between Angular and React).

@ionitron-bot ionitron-bot bot added the triage label Jul 27, 2022
@sean-perkins
Copy link
Contributor Author

cc: @milang for visibility.

@sean-perkins sean-perkins added package: react @ionic/react package type: bug a confirmed bug report labels Jul 27, 2022
@ionitron-bot ionitron-bot bot removed the triage label Jul 27, 2022
@liamdebeasi
Copy link
Contributor

Here is a dev build if anyone would like test the fix: 6.1.16-dev.11658962095.1f24647d

@milang
Copy link

milang commented Jul 28, 2022

@liamdebeasi @sean-perkins I can confirm that development build 6.1.16-dev.11658962095.1f24647d works as expected in my environment. Thank you for the quick fix! I assume this fix should eventually be available in Ionic 6.2.1?

@liamdebeasi
Copy link
Contributor

Thanks for the issue. This has been resolved via #25689, and a fix will be available in an upcoming release of Ionic Framework.

@ionitron-bot
Copy link

ionitron-bot bot commented Aug 27, 2022

Thanks for the issue! This issue is being locked to prevent comments that are not relevant to the original issue. If this is still an issue with the latest version of Ionic, please create a new issue and ensure the template is fully filled out.

@ionitron-bot ionitron-bot bot locked and limited conversation to collaborators Aug 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
package: react @ionic/react package type: bug a confirmed bug report
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants