fix(nav): exclude nav from custom dialog #25689
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request checklist
Please check if your PR fulfills the following requirements:
ionic-docs
repo, in a separate PR. See the contributing guide for details.npm run build
) was run locally and any changes were pushednpm run lint
) has passed locally and any fixes were made for failuresPull request type
Please check the type of change your PR introduces:
What is the current behavior?
Issue URL: resolves #25688, resolves #25677
The issue was caused by this commit: a6f3ae6
We targeted
ion-modal .ion-page
but did not consider that.ion-page
is also used inside ofion-nav
. As a result, this changed the styles for pages inion-nav
and broke page transitions.We also considered just doing
ion-modal > .ion-page
, but there is an existing issue where multiple.ion-page
elements can be appended on subsequent modal presentations. The fix for that will take some time, so we opted to excludeion-nav
from the.ion-page
changes for now.What is the new behavior?
Does this introduce a breaking change?
Other information