Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(modal): dialog styles work on old chrome versions #26746

Merged
merged 1 commit into from
Feb 7, 2023

Conversation

liamdebeasi
Copy link
Contributor

@liamdebeasi liamdebeasi commented Feb 7, 2023

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
    • Some docs updates need to be made in the ionic-docs repo, in a separate PR. See the contributing guide for details.
  • Build (npm run build) was run locally and any changes were pushed
  • Lint (npm run lint) has passed locally and any fixes were made for failures

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Issue URL: resolves #26745

We used a complex :not selector to fix an issue noted in #25689. The better solution was to use ion-modal > .ion-page. However, at the time of #25689 there was a bug where .ion-page was mounted multiple times with inline modals in Ionic Angular. This bug no longer reproduces in the Angular playgrounds: https://ionicframework.com/docs/api/modal#custom-dialogs

What is the new behavior?

  • Custom dialog styles now use ion-modal > .ion-page to target the immediate child of the modal.

Note: I am merging this into feature-6.6 to de-risk this. I tested this, and it works correctly on the custom dialog playgrounds.

Dev Build: 6.5.3-dev.11675782754.10ad7d4a

Does this introduce a breaking change?

  • Yes
  • No

Other information

@stackblitz
Copy link

stackblitz bot commented Feb 7, 2023

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@github-actions github-actions bot added the package: core @ionic/core package label Feb 7, 2023
@liamdebeasi liamdebeasi marked this pull request as ready for review February 7, 2023 15:10
@liamdebeasi liamdebeasi requested a review from a team as a code owner February 7, 2023 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package: core @ionic/core package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants