fix(navigation): keep the click block up longer if the keyboard is open #6884
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keep the click block up longer if the keyboard is open closes #6540
| @@ -1178,7 +1178,12 @@ export class NavController extends Ion { | |||
| transAnimation.duration(0); | |||
| } | |||
|
|
|||
| let duration = transAnimation.getDuration(); | |||
| let KEYBOARD_DURATION_PADDING = 0; | |||
There was a problem hiding this comment.
rename KEYBOARD_DURATION_PADDING to keyboardDurationPadding
…adding changed formatting, reduced keyboard duration padding
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR adds 700ms of padding to the duration if the keyboard is open. Typically on iOS, it takes about ~550ms of time to close the keyboard on my iPhone 6S. Once the transition is complete, the click block is disabled per the existing app logic. Basically, this has minimal to none effect on Android. On iOS, where it takes a bit to dismiss the keyboard, this prevents another transition from happening until the transition is complete, which will take ~550ms longer than usual when the keyboard is open.