Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(navigation): keep the click block up longer if the keyboard is open #6884

Merged
merged 2 commits into from
Jun 13, 2016
Merged

fix(navigation): keep the click block up longer if the keyboard is open #6884

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e20686c
fix(navigation): keep the click block up longer if the keyboard is open
danbucholtz Jun 13, 2016
49beb1e
refactor(navigation): changed formatting, reduced keyboard duration p…
danbucholtz Jun 13, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion src/components/nav/nav-controller.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1178,7 +1178,12 @@ export class NavController extends Ion {
transAnimation.duration(0);
}

let duration = transAnimation.getDuration();
let KEYBOARD_DURATION_PADDING = 0;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rename KEYBOARD_DURATION_PADDING to keyboardDurationPadding

if ( this._keyboard.isOpen() ){
// add 700ms to the click block just to be sure the keyboard is closed
Copy link
Contributor

@adamdbradley adamdbradley Jun 13, 2016 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove any specifics about the actual time in the comments, since it'll probably change. so // add XXms

Also, you're adding time to the app being disabled.

KEYBOARD_DURATION_PADDING = 700;
}
let duration = transAnimation.getDuration() + KEYBOARD_DURATION_PADDING;
let enableApp = (duration < 64);
// block any clicks during the transition and provide a
// fallback to remove the clickblock if something goes wrong
Expand Down