Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added settings for AdaptiveLspServer in FSAC #1781

Merged
merged 2 commits into from
Oct 9, 2022

Conversation

TheAngryByrd
Copy link
Member

Flag to allow ionide/FsAutoComplete#1007 to be used in ionide

@TheAngryByrd TheAngryByrd marked this pull request as ready for review October 2, 2022 21:52
Copy link
Contributor

@baronfel baronfel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM, but let's wait to merge until ionide/FsAutoComplete#1007 merges and releases, then we can update FSAC itself in this PR as well. That way there's never a point in time where a use can select Ionide options that will crash the FSAC instance.

@baronfel
Copy link
Contributor

baronfel commented Oct 9, 2022

Very happy to have this in.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants