Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added settings for AdaptiveLspServer in FSAC #1781

Merged
merged 2 commits into from
Oct 9, 2022
Merged

Added settings for AdaptiveLspServer in FSAC #1781

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8912765
Added settings for AdaptiveLspServer in FSAC
TheAngryByrd Sep 13, 2022
2a0a875
changelogs
baronfel Oct 9, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions RELEASE_NOTES.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,7 @@
### 7.3.0 - 09.10.2022

* Update and use FSAC 0.58.0 to get the new experimental adaptive mode.

### 7.2.3 - 06.10.2022

* Update VSCode bindings to fix add and remove file commands
Expand Down
2 changes: 1 addition & 1 deletion paket.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -285,4 +285,4 @@ STORAGE: PACKAGES
RESTRICTION: == netstandard2.0
NUGET
remote: https://api.nuget.org/v3/index.json
fsautocomplete (0.57.4)
fsautocomplete (0.58)
7 changes: 6 additions & 1 deletion release/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -461,6 +461,11 @@
"description": "Sets the root path for finding locating the dotnet CLI binary. Defaults to the \u0060dotnet\u0060 binary found on your system PATH.",
"type": "string"
},
"FSharp.enableAdaptiveLspServer": {
"default": false,
"description": "EXPERIMENTAL. Enables Enable LSP Server based on FSharp.Data.Adaptive. This can improve stability. Requires restart.",
"type": "boolean"
},
"FSharp.enableAnalyzers": {
"default": false,
"description": "EXPERIMENTAL. Enables F# analyzers for custom code diagnostics. Requires restart.",
Expand Down Expand Up @@ -1597,4 +1602,4 @@
"url": "https://github.com/ionide/ionide-vscode-fsharp.git"
},
"version": "7.2.3"
}
}
4 changes: 4 additions & 0 deletions src/Core/LanguageService.fs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -663,6 +663,8 @@ Consider:

let getOptions (c: ExtensionContext) : JS.Promise<Executable> =
promise {
let enableAdaptiveLspServer =
"FSharp.enableAdaptiveLspServer" |> Configuration.get false

let backgroundSymbolCache =
"FSharp.enableBackgroundServices" |> Configuration.get true
Expand Down Expand Up @@ -787,6 +789,8 @@ Consider:
yield "--background-service-enabled"
if enableProjectGraph then
yield "--project-graph-enabled"
if enableAdaptiveLspServer then
yield "--adaptive-lsp-server-enabled"
if verbose then
yield "--verbose"
if fsacSilencedLogs <> null && fsacSilencedLogs.Length > 0 then
Expand Down