fix: wrap controlplaneEndpoint in [], if provided address is an IPv6 address #145

pborn-ionos · 2024-03-15T13:40:19Z

Hopefully fixes #143.

mcbenjemaa

LGTM if Tested

internal/webhook/proxmoxcluster_webhook.go

…address Fixes #143.

sonarcloud · 2024-03-15T14:47:47Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

mcbenjemaa

LGTM

pborn-ionos had a problem deploying to e2e March 15, 2024 13:40 — with GitHub Actions Failure

pborn-ionos force-pushed the fix-143 branch from 13f37f4 to 4ccd1df Compare March 15, 2024 13:44

pborn-ionos had a problem deploying to e2e March 15, 2024 13:44 — with GitHub Actions Failure

pborn-ionos force-pushed the fix-143 branch from 4ccd1df to 125ff26 Compare March 15, 2024 13:45

pborn-ionos had a problem deploying to e2e March 15, 2024 13:45 — with GitHub Actions Failure

pborn-ionos force-pushed the fix-143 branch from 125ff26 to cfd0443 Compare March 15, 2024 13:47

pborn-ionos had a problem deploying to e2e March 15, 2024 13:47 — with GitHub Actions Failure

pborn-ionos force-pushed the fix-143 branch from cfd0443 to 34485a5 Compare March 15, 2024 13:48

pborn-ionos had a problem deploying to e2e March 15, 2024 13:48 — with GitHub Actions Failure

pborn-ionos force-pushed the fix-143 branch from 34485a5 to 68b054a Compare March 15, 2024 13:54

pborn-ionos had a problem deploying to e2e March 15, 2024 13:54 — with GitHub Actions Failure

mcbenjemaa previously approved these changes Mar 15, 2024

View reviewed changes

pborn-ionos dismissed mcbenjemaa’s stale review via a9949bf March 15, 2024 13:56

pborn-ionos force-pushed the fix-143 branch from 68b054a to a9949bf Compare March 15, 2024 13:56

pborn-ionos had a problem deploying to e2e March 15, 2024 13:56 — with GitHub Actions Failure

mcbenjemaa reviewed Mar 15, 2024

View reviewed changes

internal/webhook/proxmoxcluster_webhook.go Show resolved Hide resolved

fix: wrap controlplaneEndpoint in [], if provided address is an IPv6 …

10c8bea

…address Fixes #143.

pborn-ionos force-pushed the fix-143 branch from a9949bf to 10c8bea Compare March 15, 2024 14:46

pborn-ionos temporarily deployed to e2e March 15, 2024 14:46 — with GitHub Actions Inactive

pborn-ionos marked this pull request as ready for review March 18, 2024 09:29

pborn-ionos requested review from 65278, avorima, lubedacht and wikkyk as code owners March 18, 2024 09:29

mcbenjemaa approved these changes Mar 18, 2024

View reviewed changes

pborn-ionos merged commit 0b7d163 into main Mar 18, 2024
8 checks passed

pborn-ionos deleted the fix-143 branch March 18, 2024 10:21

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: wrap controlplaneEndpoint in [], if provided address is an IPv6 address #145

fix: wrap controlplaneEndpoint in [], if provided address is an IPv6 address #145

pborn-ionos commented Mar 15, 2024

mcbenjemaa left a comment

sonarcloud bot commented Mar 15, 2024

mcbenjemaa left a comment

fix: wrap controlplaneEndpoint in [], if provided address is an IPv6 address #145

fix: wrap controlplaneEndpoint in [], if provided address is an IPv6 address #145

Conversation

pborn-ionos commented Mar 15, 2024

mcbenjemaa left a comment

Choose a reason for hiding this comment

sonarcloud bot commented Mar 15, 2024

Quality Gate passed

mcbenjemaa left a comment

Choose a reason for hiding this comment