Use prettier to format .md files #860
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
willclarktech
suggested changes
Mar 27, 2019
| @@ -18,6 +18,7 @@ | |||
| "scripts": { | |||
| "bootstrap": "lerna bootstrap", | |||
| "format": "lerna run format", | |||
There was a problem hiding this comment.
I would expect the format script to cover the root as well.
There was a problem hiding this comment.
The default "format" implementation is prettier --write --loglevel warn \"./src/**/*.ts\", which does not do anything in the root dir. Thus I did not add it here.
| @@ -18,6 +18,7 @@ | |||
| "scripts": { | |||
| "bootstrap": "lerna bootstrap", | |||
| "format": "lerna run format", | |||
| "format-text": "prettier --write --prose-wrap always --print-width 80 \"./*.md\" \"./docs/**/*.md\" && lerna run format-text", | |||
There was a problem hiding this comment.
No:
lerna run <script>
Run an npm script in each package that contains that script
i.e. lerna run format-text runs yarn format-text for each folder in packages/ only.
There was a problem hiding this comment.
Ah, right. lerna run not yarn run.
willclarktech
suggested changes
Mar 27, 2019
In this case the change from to caused the second run to interprete it as a h2. Will fix manually |
willclarktech
approved these changes
Mar 27, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First step for #829
The idea is to format code and text separatly