Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate from jasmine2-custom-message to native withContext() #954

Merged
merged 1 commit into from
May 1, 2019
Merged

Migrate from jasmine2-custom-message to native withContext() #954

merged 1 commit into from
May 1, 2019

Conversation

webmaster128
Copy link
Contributor

Remove hardly used dependency

willclarktech
willclarktech approved these changes May 1, 2019
View reviewed changes
Copy link
Contributor

@willclarktech willclarktech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool feature

@willclarktech willclarktech merged commit 92b6eaa into master May 1, 2019
@willclarktech willclarktech deleted the rm-jasmine2-custom-message branch May 1, 2019 08:14
@webmaster128
Copy link
Contributor Author

Cool feature

Good to have this natively for the cases where you really need to loop over test data, yeah. However, I don't link how it is integrated into the expect syntax as it breaks the reability of the tests (expect X with contect data number Y to equal Z).

@willclarktech willclarktech mentioned this pull request May 2, 2019
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@willclarktech willclarktech willclarktech approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@webmaster128 @willclarktech