This repository has been archived by the owner on Mar 10, 2020. It is now read-only.
Fix/object patch #220
Merged
Fix/object patch #220
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #124 (Cannot declare a parameter named 'mask' as it shadows the name of a strict mode function)
All methods return a promise when not passed a callback Closes #80
feat: Add promise based api
refactor: Update dependencies to latest
js-ipfs serves a content type including the charset `application/json; charset=utf-8` so the previous check for json failed, resulting in non parsed json. Fixes https://github.com/ipfs/js-ipfs/pull/69/files#r53560321
fix(request): Improve json content-type detection
Avoid calling the cb twice when statusCode > 400
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.