Use dignified.js #233
Use dignified.js #233
Conversation
|
Started extraction into: https://github.com/dignifiedquire/dignified.js |
| @@ -82,7 +82,8 @@ function loadPaths (opts, file) { | |||
| // files inside symlinks and others | |||
| return | |||
| }) | |||
| .filter((file) => !!file) // filter out null files | |||
| // filter out null files | |||
| .filter((f) => Boolean(f)) | |||
There was a problem hiding this comment.
Oh nice, didn't know about this wrapper. We can make it just .filter(Boolean), right?
There was a problem hiding this comment.
That's how "type casting" in js is done, exists for all the types Number, Boolean, String.
Yes we can do.
|
I feel that we will need to improve the docs on 'why the heck, so many folders auto generated', but this is looking good :):) Travis stopped being happy though. Just to make sure we should run our tests with the original src tree and the babel transpiled es5 compatible one too. We might catch some errors and avoid users some pain. |
|
Ref ipfs/aegir#1 |
daviddias
force-pushed
the
feat/files-api
branch
from
1fb59eb
to
3e23a91
Compare
Update to be compatible with IPFS 0.4.0
|
@dignifiedquire could you resubmit this PR to master? Thank you |
dignifiedquire
force-pushed
the
dignified
branch
from
5d220df
to
04e3b49
Compare
This is only for discussions for now.
Implemented
cc @diasdavid @nginnever
Ref ipfs/community#111