-
Notifications
You must be signed in to change notification settings - Fork 299
Update to be compatible with IPFS 0.4.0 #74
Conversation
ipfs.files.rm(<path>, [<options>], function (err) {}) | ||
``` | ||
|
||
For `rm -r` pass a options obj with `r: true` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would be noce to have recursive: true
as an alias for r: true
as that is much more readable in code segment. Also is this the only option that can be passed atm?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It should be able to accept any of the options that is available through the cli.
(ref: #58 how is the new README going? Anything I could pull and use the new format to add the remaining options?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Right, but would be nice if that's documented here :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I definitely agree:) added to the WIP todo to make it explicit
@diasdavid this needs some updating I think ;) |
Yeah, I need to rebase, but it works quite nicely, ipfs-blob-store uses it :) Can't wait for 0.4.0 to be released for this to be part of the global set |
f5ae644
to
13f2c92
Compare
Now with all the latest and greatest fancy sparkles from 2.9.3 :) |
"ignore": [ | ||
"dist/*" | ||
] | ||
}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not needed anymore
@whyrusleeping, repro:
note, use latest dev0.4.0 |
@@ -28,7 +28,7 @@ function onRes (buffer, cb) { | |||
const isJson = res.headers['content-type'] === 'application/json' | |||
|
|||
if (res.statusCode >= 400 || !res.statusCode) { | |||
const error = new Error(`Server responded with ${res.statusCode}`) | |||
let error = new Error(`Server responded with ${res.statusCode}`) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
??
2d6778c
to
d2fa958
Compare
woot! so we have files-api using latest 0.4.0 + ipfs/kubo#2046 @nginnever just pushed also a new dist so you can use it on the browser :) |
|
Chya! Danke! Now I don't have to learn webpack today :) |
Fix/object patch
Add symlink support to feat/files-api
docs: Update api docs
6955091
to
1fb59eb
Compare
1fb59eb
to
3e23a91
Compare
wooooo it's green! :D //cc @haadcode @harlantwood @dignifiedquire @nginnever @RichardLitt @xicombd @victorbjelkholm and all the people that have contributed or looked for this version for quite some time, it is here! Thank you :) |
Wooo! |
WIP: