Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add check to verify the CID is fetchable before returning it #14

Open
olizilla opened this issue Jan 20, 2021 · 0 comments · May be fixed by #15
Open

Add check to verify the CID is fetchable before returning it #14

olizilla opened this issue Jan 20, 2021 · 0 comments · May be fixed by #15
Assignees
@olizilla

Comments

@olizilla
Copy link
Member

It is worth being defensive here and verifying that a CID can be fetched before returning it to the calling CI code, so a CI based deploy fails rather than proceeding and deploying a unfetchable CID.
@olizilla olizilla self-assigned this Jan 20, 2021
olizilla added a commit that referenced this issue Jan 21, 2021
@olizilla
feat: check cid can be fetched from the gateway
e92fa33 
Check that the newly pinned CID can be fetched from the gateway

fixes #14

License: MIT
Signed-off-by: Oli Evans <[email protected]>
@olizilla olizilla linked a pull request Jan 21, 2021 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@olizilla olizilla

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: check cid can be fetched from the gateway ipfs-shipyard/ipfs-dns-deploy
1 participant
@olizilla