feat: check cid can be fetched from the gateway #15
Conversation
Check that the newly pinned CID can be fetched from the gateway fixes #14 License: MIT Signed-off-by: Oli Evans <[email protected]>
|
This is quite defensive, slight worry we might have the opposite problem of builds failing even though nothing is wrong. Perhaps try twice or something? |
|
Aye that's a fair point, I don't want all the builds to fail, just the really bad ones. I'll add some retry. |
License: MIT Signed-off-by: Oli Evans <[email protected]>
| # Wait 60s for a response. Wait 10s after a failure. Try the same again, twice. | ||
| can_get_from_gateway=$(curl ---max-time 60 --retry 2 --retry-delay 10 --retry-connrefused --fail --silent --show-error "$preview_url") || { |
There was a problem hiding this comment.
@thattommyhall how about dis?
| # Attempt to fetch the CID. | ||
| # Ignore the response, but fail on error. | ||
| # Wait 60s for a response. Wait 10s after a failure. Try the same again, twice. | ||
| can_get_from_gateway=$(curl ---max-time 60 --retry 2 --retry-delay 10 --retry-connrefused --fail --silent --show-error "$preview_url") || { |
There was a problem hiding this comment.
Wouldn't it make more sense to test whether this CID is available on the cluster ?
There was a problem hiding this comment.
Yes! I was going to go that route here, but then parsing the the output of the ipfs-cluster-ctl status command was a little messy and had to make an assumption about the replication factor for the pin.
Adding the ipfs-cluster-ctl add --wait flag will do that job in a more robust way, and I'll add that to this PR if it lands soon, or i'll raise a new one to add it later.
Check that the newly pinned CID can be fetched from the gateway. Fail the build if not.
fixes #14
License: MIT
Signed-off-by: Oli Evans [email protected]