Outgoing Request Hooks, swapping persistence layers #61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rename hooks, add outgoing request hook, define chain types for node builder chooser tests
add persistence options to asyncloader & responsemanager + handling
This was referenced Apr 7, 2020
Stebalien
reviewed
Apr 8, 2020
| for _, requestHook := range rm.requestHooks { | ||
| requestHook.hook(p, request, ha) | ||
| if ha.err != nil { | ||
| rm.requestHooksLk.RUnlock() | ||
| rm.persistenceOptionsLk.RUnlock() |
There was a problem hiding this comment.
uber-nit: I'd be consistent in the order in which we release these locks (not necessary at all, just slightly nicer).
| response := make(chan error, 1) | ||
| select { | ||
| case <-al.ctx.Done(): | ||
| return errors.New("context closed") |
There was a problem hiding this comment.
nit: "async loader closed". ditto below
| err := rpom.register(al) | ||
| select { | ||
| case <-al.ctx.Done(): | ||
| case rpom.response <- err: |
There was a problem hiding this comment.
isn't this channel guaranteed to be buffered?
| case al.incomingMessages <- &startRequestMessage{requestID}: | ||
| return errors.New("context closed") | ||
| case err := <-response: | ||
| return err |
There was a problem hiding this comment.
may be simpler to just guarantee that we process all inbound requests. incomingMessages isn't buffered anyways so we can guarantee that we send back a response for all incoming messages we receive.
| // fall back to local store | ||
| stream, loadErr := loader(link, ipld.LinkContext{}) | ||
| if stream != nil && loadErr == nil { | ||
| localData, loadErr := ioutil.ReadAll(stream) |
There was a problem hiding this comment.
This is safe as long as we're sure we trust the local store. Probably fine, just calling this out to make sure.
marten-seemann
pushed a commit
that referenced
this pull request
Mar 2, 2023
* build(scripts): add imports + release scripts * style(imports): fix import style use standard import style via script * ci(circle): add imports-check, cbor-gen-check * docs(CHANGELOG): add changelog with releases record
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goals
Background on the needs here:
Implementation
This builds on the previous addition of swapping the loader and node-builder-chooser on the response side with similar hooks on the request side. Because the request side has to deal with storing as well as loading, and in order to not end up with duplicate store operations, I've decided to uniquely identify loader/storer combos as alternate persistence options, distinguished by a unique string name. (toyed with trying to not require the string name, but as you know, go is not good with comparability in function types)
Implementation: