Improve perf by reducing calls to mh.toB58String #82
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dignifiedquire
changed the title
|
Latest orbit build including these changes: https://ipfs.io/ipfs/QmZBWsCwgQ6x7ZSBWXufAFirKJ64j39r6yygTm31sdCrMY |
|
@dignifiedquire could you please PR this against the bitswap 1.1.0? This will cause a bunch of annoying merge conflicts and for the time being, it is not a priority, can easily be shipped by next week with the other PR |
|
Given these changes are ready to be used and very helpful I don't think it makes sense to delay them untill the 1.1 PR is ready. I will have to redo most of this anyway for that branch, so lets ship this so it can be used amd I will rebase and fixup the 1.1 branch afterwards. |
Closed
|
Closing in favor of #83 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were abusing this encoding very heavily. Ref libp2p/js-peer-id#44