feat: cache b58 id #44
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
On a (maybe) related note, I had troubles with slow transfers between chrome and chrome, others work fine. ipfs/js-ipfs#611 |
This was referenced Dec 14, 2016
daviddias
suggested changes
Dec 18, 2016
| @@ -17,11 +17,16 @@ class PeerId { | |||
| assert(privKey.public.bytes.equals(pubKey.bytes), 'inconsistent arguments') | |||
| } | |||
|
|
|||
| this.id = id | |||
| this._id = id | |||
| this._idB58String = '' | |||
There was a problem hiding this comment.
done, also throwing now on id mutation
daviddias
approved these changes
Dec 18, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While investigating slow performance in js-ipfs I discovered that there are too many calls to
mh.toB58String. This is the start of reducing the number of those calls.