Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: move to travis #190

Merged
merged 6 commits into from
Feb 14, 2019
Merged

chore: move to travis #190

merged 6 commits into from
Feb 14, 2019

Conversation

jacobheun
Copy link
Contributor

No description provided.

@ghost ghost assigned jacobheun Feb 13, 2019
@ghost ghost added the status/in-progress In progress label Feb 13, 2019
@jacobheun
Copy link
Contributor Author

@hugomrdias have you see this windows error? https://travis-ci.com/ipfs/js-ipfs-repo/jobs/177507079

I think ipfs-repo had issues with it in the past, but we haven't had any recent issues with it on jenkins.

@jacobheun
Copy link
Contributor Author

Looks like this was previously fixed with a git config change #153 (comment)

@ghost ghost assigned hugomrdias Feb 13, 2019
@hugomrdias
Copy link
Member

@jacobheun this is ready to be merged

@jacobheun
Copy link
Contributor Author

@hugomrdias any idea why PR is failing but branch is passing? I tried re-running the PR build with cleared cache but Windows is still failing. Perhaps the PR commit being tested is messing with the line endings?

@hugomrdias
Copy link
Member

its normal because the PR run is done on the merge commit and master doesn't have the gitattributes yep.
after we merge this PR, all future PRs will have both pipelines green.

@jacobheun jacobheun merged commit 23f49f2 into master Feb 14, 2019
@ghost ghost removed the status/in-progress In progress label Feb 14, 2019
@jacobheun jacobheun deleted the chore/travis branch February 14, 2019 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants