This repository has been archived by the owner on Feb 12, 2024. It is now read-only.
Essential Tests for Feat/gateway #997
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* clean up, remove commented out lines. * cleaning code, removing commented out blocks. * gateway initial tests.
License: MIT Signed-off-by: Yahya <[email protected]>
License: MIT Signed-off-by: Yahya <[email protected]>
…checks License: MIT Signed-off-by: Yahya <[email protected]>
License: MIT Signed-off-by: Yahya <[email protected]>
* feat: add gateway route to daemon * feat: adding Gateway endeavour - improve codebase * clean up, remove commented out lines. (ipfs#971) * clean up, remove commented out lines. * cleaning code, removing commented out blocks. * gateway initial tests. * clean up , working tests on node v8.4.0 License: MIT Signed-off-by: Yahya <[email protected]> * fix using js-ipfs-repo in gateway tests. License: MIT Signed-off-by: Yahya <[email protected]> * Using unix-fs to detect dirs, replacing object.get with DAG.get, CID checks License: MIT Signed-off-by: Yahya <[email protected]> * rename checkHash -> checkCID License: MIT Signed-off-by: Yahya <[email protected]> * gateway tests: init a fresh repo
License: MIT Signed-off-by: Yahya <[email protected]>
License: MIT Signed-off-by: Yahya <[email protected]>
…eat/gateway License: MIT Signed-off-by: Yahya <[email protected]>
|
@ya7ya this is really cool! Just one small but important request. It seems that history is getting messed up by your local out of date version of the repo. Could you make the last changes to a new branch starting off from #968 latest commit? Note for example that now the html and style is on a dir-view folder, which is not present here in your PR. |
|
@diasdavid sure, I'll fix the repo history and push it to a new branch 👍 |
6 tasks
|
closing this in favor of #999 |
MicrowaveDev
pushed a commit
to galtproject/js-ipfs
that referenced
this pull request
May 22, 2020
* fix: error handling for refs/refs local * fix: ensure errors are passed back from stream-to-value * chore: update interface-ipfs-core
This was referenced Jan 20, 2022
This was referenced Oct 17, 2022
This was referenced Oct 17, 2022
This was referenced Oct 17, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey @diasdavid , These are the essential tests you mentioned in #968
Changes:
I wasn't Able to reproduce the error you mentioned . But the tests went fine.
side fix:
examples/traverse-ipld-graph/git.jskept throwing an error when linting, so I had to fix those in order to commit.