Skip to content
This repository has been archived by the owner on Feb 12, 2024. It is now read-only.

[FIXED] Essential Tests for Feat/gateway #999

Merged
merged 2 commits into from
Sep 6, 2017

Conversation

ya7ya
Copy link
Contributor

@ya7ya ya7ya commented Sep 6, 2017

[FIXED] Repo history #997

Hey @diasdavid , These are the essential tests you mentioned in #968

Changes:

  • interface tests
  • Fetching a file with a mime-type that is not text (i.e a pdf or an image)
  • Loading a webpage (one for each type of index.html)
  • Loading a webpage from a pagh (QmHASH/a/b/c -> loads the webpage in that path)
  • Loading bigFile
  • CORS tests (make sure config is respected)

I wasn't Able to reproduce the error you mentioned . But the tests went fine.

side fix: examples/traverse-ipld-graph/git.js kept throwing an error when linting, so I had to fix those in order to commit.

@ya7ya ya7ya mentioned this pull request Sep 6, 2017
6 tasks
Copy link
Member

@daviddias daviddias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just needs the interface tests to be removed as they don't belong here.

describe('## interface tests', () => {
fs.readdirSync(path.join(__dirname, '/interface'))
.forEach((file) => require('./interface/' + file))
})
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ya7ya why did you bring these tests back? These are designed for the API, not for the gateway.

@ya7ya
Copy link
Contributor Author

ya7ya commented Sep 6, 2017

@diasdavid Interface tests removed from gateway. Sorry about that.

@daviddias daviddias merged commit 513c4ba into ipfs:feat/gateway Sep 6, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants