Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Commands Library Upgrade #5664

Closed
73 tasks done
Stebalien opened this issue Oct 26, 2018 · 6 comments
Closed
73 tasks done

Commands Library Upgrade #5664

Stebalien opened this issue Oct 26, 2018 · 6 comments
Labels
topic/meta Topic meta

Comments

@Stebalien
Copy link
Member

Stebalien commented Oct 26, 2018

Given the amount of interest in updating commands-lib commands to the latest commands-lib version (and the recently fixed bugs in MakeTypedEncoder), let's have a meta-issue.

General suggestions:

  1. Prefer MakeTypedEncoder, it removes some boilerplate.
  2. Old encoders tended to return NewReader(someByteBufferOrString). In new code, prefer writing directly to the provided writer instead of first building up a temporary buffer/string.

Please comment below with the commands you're planning on fixing (just that).
They'll be checked off when actually fixed.

@qiwaa
Copy link
Contributor

qiwaa commented Oct 27, 2018

I am planning to help with ipfs repo.

@kevina

This comment has been minimized.

@overbool

This comment has been minimized.

@kevina

This comment has been minimized.

@overbool
Copy link
Contributor

@Stebalien Maybe this issue can be closed.

@Stebalien
Copy link
Member Author

Yep. Thanks for the reminder.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic/meta Topic meta
Projects
None yet
Development

No branches or pull requests

4 participants