-
-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Commands Library Upgrade #5664
Labels
topic/meta
Topic meta
Comments
This was referenced Oct 26, 2018
This was referenced Oct 26, 2018
I am planning to help with |
This was referenced Oct 27, 2018
This was referenced Oct 27, 2018
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
@Stebalien Maybe this issue can be closed. |
Yep. Thanks for the reminder. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Given the amount of interest in updating commands-lib commands to the latest commands-lib version (and the recently fixed bugs in MakeTypedEncoder), let's have a meta-issue.
General suggestions:
MakeTypedEncoder
, it removes some boilerplate.NewReader(someByteBufferOrString)
. In new code, prefer writing directly to the provided writer instead of first building up a temporary buffer/string.Please comment below with the commands you're planning on fixing (just that).
They'll be checked off when actually fixed.
ls
command #5611 commands/ls: use new cmds lib #5663The text was updated successfully, but these errors were encountered: