commands/pin: use new cmds lib

[overbool]

Refer: #5664

License: MIT
Signed-off-by: Overbool [email protected]

[kevina]

Due to an oddity with how parsing arguments from Stdin works, when ever you have a command that can accept more than one argument from Stdin you must either call req.ParseBodyArgs() before using req.Arguments or iterate over them with req.BodyArgs(), with the former being preferred for now. If you don't only the first argument will be read from Stdin.

You can test this my trying to pass two arguments via the command line to an affected command and then try again via Stdin.

[overbool]

@kevina I found that req.Arguments only contain the first arg if I pass two arguments from Stdin

[kevina]

@kevina I found that req.Arguments only contain the first arg if I pass two arguments from Stdin.

Correct. To fix this you need to call req.ParseBodyArgs() before using req.Arguments.

[kevina]

@overbool this needs a rebase now.

I would like to get this in ASAP. Let me know if you need any help with this.

[overbool]

@kevina Sorry for my delay. I had replaced the Encoder with PostRun and fixed some bugs. Could u help me review it again?

[kevina]

One nit. But otherwise LGTM.

[kevina]

LGTM.

[Stebalien]

So, technically, this breaks curl http://localhost:5001/api/v0/pin/add/...?enc=text. I believe the correct way to do this is: overbool#1. That is, handle status in a post-run but forward everything else to the encoder.