refactor: stop using go-libp2p deprecated peer.ID.Pretty #10121
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Icarus9913
force-pushed
the
libp2p/remove-deprecated-method
branch
from
92da467
to
9a96694
Compare
|
I see 19 files that use |
Icarus9913
force-pushed
the
libp2p/remove-deprecated-method
branch
from
9a96694
to
1b77f2c
Compare
All cleaned |
Icarus9913
force-pushed
the
libp2p/remove-deprecated-method
branch
2 times, most recently
from
ec4831c
to
0058a81
Compare
marten-seemann
approved these changes
Sep 12, 2023
|
@ipfs/kubo-maintainers For some context, we're planning to remove the deprecated method in the next release: libp2p/go-libp2p#2565. Merging this PR early will make updating to next release easier. |
hacdias
requested changes
Sep 12, 2023
Signed-off-by: Icarus9913 <[email protected]>
Icarus9913
force-pushed
the
libp2p/remove-deprecated-method
branch
from
0058a81
to
4ba5a95
Compare
hacdias
approved these changes
Sep 18, 2023
hacdias
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
go-libp2ppeerID Pretty method is already deprecated, switch it to call String method.Signed-off-by: Icarus9913 [email protected]