core/peer: remove deprecated ID.Pretty method #2565
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marten-seemann
force-pushed
the
remove-peer-id-pretty
branch
from
682cb85
to
85474d7
Compare
sukunrt
approved these changes
Sep 11, 2023
marten-seemann
commented
Sep 11, 2023
|
Just putting this out there, this will require some amount of cleanup for our users:
I still think we should go ahead with the removal, the whole purpose of deprecation is that we can eventually clean up our API. |
|
cc @p-shahi for visibility |
This was referenced Sep 12, 2023
distractedm1nd
added a commit
to distractedm1nd/go-libp2p
that referenced
this pull request
Oct 12, 2023
This reverts commit 32f9239.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This method has been deprecated for more than a year now.