Node accessor renames #27
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These have been just slightly out of style for a while now. (In particular, allusions to numeric-keyed maps are removed. While these are still considered a potential "someday" subject rather than fully ruled out, it's also certainly not a *present* feature; until something changes on this front, better not to advertise it.) Signed-off-by: Eric Myhre <[email protected]>
Most important things first! To follow this refactor: ``` sed s/TraverseField/LookupString/g sed s/TraverseIndex/LookupIndex/g ``` It is *literally* a sed-refactor in complexity. --- Now, details. This has been pending for a while, and there is some discussion in #22 . In short, "Traversal" seemed like a mouthful; "Field" was always a misnomer here; and we've discovered several other methods that we *should* have in the area as well, which necessitated a thought about placement. In this commit, only the renames are applied, but you can also see the outlines of two new methods in the Node interface, as comments. These will be added in future commits. Signed-off-by: Eric Myhre <[email protected]>
Signed-off-by: Eric Myhre <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #27 +/- ##
======================================
Coverage 56.2% 56.2%
======================================
Files 37 37
Lines 1783 1783
======================================
Hits 1002 1002
Misses 691 691
Partials 90 90
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #22 .
This changes some exported symbols! To follow this refactor:
The textual update should be sufficient -- semantics are the same.