Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Node accessor renames #27

Merged
merged 3 commits into from
Aug 12, 2019
Merged

Node accessor renames #27

merged 3 commits into from
Aug 12, 2019

Commits on Aug 12, 2019

  1. Fixup on docs strings on Node methods. 

    These have been just slightly out of style for a while now.

(In particular, allusions to numeric-keyed maps are removed.
While these are still considered a potential "someday" subject rather
than fully ruled out, it's also certainly not a *present* feature;
until something changes on this front, better not to advertise it.)

Signed-off-by: Eric Myhre <[email protected]>
    @warpfork
    warpfork committed Aug 12, 2019
    Configuration menu
    Copy the full SHA
    256c605 View commit details
    Browse the repository at this point in the history

  2. Node traversal(->lookup) method renames. 

    Most important things first!  To follow this refactor:

```
sed s/TraverseField/LookupString/g
sed s/TraverseIndex/LookupIndex/g
```

It is *literally* a sed-refactor in complexity.

---

Now, details.

This has been pending for a while, and there is some discussion in
#22 .

In short, "Traversal" seemed like a mouthful;
"Field" was always a misnomer here;
and we've discovered several other methods that we *should* have
in the area as well, which necessitated a thought about placement.

In this commit, only the renames are applied, but you can also see
the outlines of two new methods in the Node interface, as comments.
These will be added in future commits.

Signed-off-by: Eric Myhre <[email protected]>
    @warpfork
    warpfork committed Aug 12, 2019
    Configuration menu
    Copy the full SHA
    2e3868c View commit details
    Browse the repository at this point in the history

  3. Fix docs references missed by exact string match. 

    Signed-off-by: Eric Myhre <[email protected]>
    @warpfork
    warpfork committed Aug 12, 2019
    Configuration menu
    Copy the full SHA
    40bacb4 View commit details
    Browse the repository at this point in the history