-
Notifications
You must be signed in to change notification settings - Fork 603
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Delete duplicated tests in iree/test/e2e/ #5446
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lets keep this for now. If you want you can create a new column on Linalg on tensors project, and add this PR to that
The flag is not used. It now looks into the target backend to decide whether dispatch Linalg on tensors. I can make it still usable so you can control the behavior easier. I'd like to delete duplicated and outdated e2e tests at least because it blocks mhlo.fft end-to-end testing. mhlo.fft only works in Linalg on tensors. What do you think? |
I think deleting the tests is fine. We might still need the old flag to run the legacy path for perf comparison for maybe a week or so. |
Okay, I will make the flag work and delete the duplicate tests in this PR instead. |
@@ -32,6 +32,12 @@ | |||
#include "mlir/Pass/PassRegistry.h" | |||
#include "mlir/Transforms/Passes.h" | |||
|
|||
static llvm::cl::opt<bool> clEnableLinalgOnTensorsDispatch( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be default true?
@@ -74,9 +74,6 @@ iree_check_single_backend_test_suite( | |||
"vectorized_conv.mlir", | |||
], | |||
compiler_flags = [ | |||
"-iree-flow-dispatch-linalg-on-tensors", | |||
"-iree-codegen-spirv-experimental-linalg-on-tensors", | |||
"-iree-spirv-enable-vectorization", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This flag probably needs to be kept (I am talking about just iree-spirv-enable-vectorization
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, we don't need it today. Vectorization is turned on by default in Linalg on tensors, see #5280
Also delete unnecessary flags in iree/test/e2e and iree/compiler/Dialect/HAL/Target/LLVM/test/smoketest.mlir
Part of #5442