Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Delete duplicated tests in iree/test/e2e/ #5446

Merged
merged 3 commits into from
Apr 19, 2021
Merged

Delete duplicated tests in iree/test/e2e/ #5446

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1ca8725
Delete iree-flow-dispatch-linalg-on-tensors flag.
hanhanW Apr 15, 2021
f79fa4d
should not remove this one...
hanhanW Apr 15, 2021
529686f
Add the flags back -- only delete duplicated tests and delete one use in
hanhanW Apr 15, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 11 additions & 3 deletions iree/compiler/Dialect/Flow/Transforms/Passes.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,12 @@
#include "mlir/Pass/PassRegistry.h"
#include "mlir/Transforms/Passes.h"

static llvm::cl::opt<bool> clEnableLinalgOnTensorsDispatch(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be default true?

"iree-flow-dispatch-linalg-on-tensors",
llvm::cl::desc(
"Enable use of Linalg on tensors for dispatch region creation."),
llvm::cl::init(false));

// TODO(benvanik): change to a pipeline option.
static llvm::cl::opt<bool> clExportBenchmarkFuncs(
"iree-flow-export-benchmark-funcs",
Expand Down Expand Up @@ -68,9 +74,11 @@ namespace Flow {
static void buildHLOInputTransformPassPipeline(OpPassManager &passManager) {
passManager.addNestedPass<FuncOp>(
IREE::Flow::createHLOToHLOPreprocessingPass());
// TODO(ataei): This should run as part of createHLOToHLOPreprocessingPass
// which will break VMLA backend.
passManager.addNestedPass<FuncOp>(createDecomposeHLOClampPass());
if (clEnableLinalgOnTensorsDispatch) {
// TODO(ataei): This should run as part of createHLOToHLOPreprocessingPass
// which will break VMLA backend.
passManager.addNestedPass<FuncOp>(createDecomposeHLOClampPass());
}

// Run passes to remove shape constraints. HLO lowering inserts them, but they
// are not desired here.
Expand Down