R4R: Split the export command into reset and export #1522
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chengwenxi
force-pushed
the
vincent/replay
branch
from
909da75
to
0830ed7
Compare
chengwenxi
changed the title
chengwenxi
requested review from
haifengxi,
julia2804,
secret2830,
zhangyelong and
dreamer-zq
haifengxi
approved these changes
Jun 4, 2019
abelliumnt
reviewed
Jun 4, 2019
| forZeroHeight := viper.GetBool(flagForZeroHeight) | ||
| appState, validators, err := appExporter(ctx, ctx.Logger, db, traceWriter, height, forZeroHeight) | ||
| appState, validators, err := appExporter(ctx, ctx.Logger, db, traceWriter, forZeroHeight) |
There was a problem hiding this comment.
Why do you remove height from export option? It is possible to export state for zero height but not at current height.
There was a problem hiding this comment.
Why do you remove height from export option? It is possible to export state for zero height but not at current height.
If you want to export state for zero or snapshoot height, reset it first.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: #1511