-
Notifications
You must be signed in to change notification settings - Fork 127
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
R4R: Split the export command into reset and export #1522
Merged
Merged
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
6f34134
Split the export command into reset and export
chengwenxi af6185e
Merge with develop
chengwenxi bd16089
Update v1 MetricsSubsystem
chengwenxi 0830ed7
Add doc about app state reset and export
chengwenxi a42dfbd
Update reset and export doc
chengwenxi File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,23 @@ | ||
# Reset Blockchain State | ||
|
||
## Description | ||
|
||
IRISnet can reset blockchain state at any height. This can be accomplished by command `iris reset`. | ||
|
||
## Usage | ||
``` | ||
iris reset <flags> | ||
``` | ||
## Flags | ||
|
||
| Name,shorthand | type | Required | Default | Description | | ||
| ------------------- | ----- | -------- | -------- | -------------- | | ||
| --height | int | false | 0 | Specify the height, default value is 0 which means to export the latest state | | ||
| --home | string | false | $HOME/.iris | Specify the directory which stores node config and blockchain data | | ||
|
||
## Examples | ||
|
||
1. Reset the blockchain state to block 100: | ||
``` | ||
iris reset --height 100 --home=<path_to_your_home> | ||
``` |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,23 @@ | ||
# 重置区块链状态 | ||
|
||
## 介绍 | ||
|
||
IRISnet支持重置区块链状态到任意高度,这里介绍重置区块链状态所用的命令为`iris reset`。 | ||
|
||
## 用法 | ||
``` | ||
iris reset <flags> | ||
``` | ||
## 标志 | ||
|
||
| Name,shorthand | type | Required | Default | Description | | ||
| ------------------- | ----- | -------- | -------- | -------------- | | ||
| --height | int | false | 0 | Specify the height, default value is 0 which means to export the latest state | | ||
| --home | string | false | $HOME/.iris | Specify the directory which stores node config and blockchain data | | ||
|
||
## 示例 | ||
|
||
1. 重置区块链状态到区块100: | ||
``` | ||
iris reset --height 100 --home=<path_to_your_home> | ||
``` |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,58 @@ | ||
package server | ||
|
||
import ( | ||
"fmt" | ||
|
||
"github.com/irisnet/irishub/codec" | ||
"github.com/pkg/errors" | ||
"github.com/spf13/cobra" | ||
"github.com/spf13/viper" | ||
) | ||
|
||
const ( | ||
flagHeight = "height" | ||
) | ||
|
||
// ResetCmd reset app state to particular height | ||
func ResetCmd(ctx *Context, cdc *codec.Codec, appReset AppReset) *cobra.Command { | ||
cmd := &cobra.Command{ | ||
Use: "reset", | ||
Short: "Reset app state to the specified height", | ||
RunE: func(cmd *cobra.Command, args []string) error { | ||
home := viper.GetString("home") | ||
traceWriterFile := viper.GetString(flagTraceStore) | ||
emptyState, err := isEmptyState(home) | ||
if err != nil { | ||
return err | ||
} | ||
|
||
if emptyState { | ||
fmt.Println("WARNING: State is not initialized.") | ||
return nil | ||
} | ||
|
||
db, err := openDB(home) | ||
if err != nil { | ||
return err | ||
} | ||
traceWriter, err := openTraceWriter(traceWriterFile) | ||
if err != nil { | ||
return err | ||
} | ||
height := viper.GetInt64(flagHeight) | ||
if height < 0 { | ||
return errors.Errorf("Height must greater than or equal to zero") | ||
} | ||
err = appReset(ctx, ctx.Logger, db, traceWriter, height) | ||
if err != nil { | ||
return errors.Errorf("Error reset state: %v\n", err) | ||
} | ||
|
||
fmt.Printf("Reset app state to height %d successfully\n", height) | ||
return nil | ||
}, | ||
} | ||
cmd.Flags().Int64(flagHeight, 0, "Reset state from a particular height (0 or greater than latest height means latest height)") | ||
cmd.MarkFlagRequired(flagHeight) | ||
return cmd | ||
} |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do you remove height from export option? It is possible to export state for zero height but not at current height.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you want to export state for zero or snapshoot height, reset it first.