Skip to content
This repository has been archived by the owner on Oct 7, 2020. It is now read-only.

add grafana storage size #545

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

yacut
Copy link

@yacut yacut commented Nov 12, 2019

related to istio/istio#18739

@yacut yacut requested a review from a team as a code owner November 12, 2019 08:41
@googlebot googlebot added the cla: yes Set by the Google CLA bot to indicate the author of a PR has signed the Google CLA. label Nov 12, 2019
@istio-testing istio-testing added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Nov 12, 2019
@istio-testing
Copy link

Hi @yacut. Thanks for your PR.

I'm waiting for a istio member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link
Member

@morvencao morvencao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ok-to-test

@istio-testing istio-testing added ok-to-test Set this label allow normal testing to take place for a PR not submitted by an Istio org member. and removed needs-ok-to-test labels Nov 13, 2019
@istio-testing
Copy link

@yacut: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
gencheck_installer 3dbc70e link /test gencheck_installer

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@sdake
Copy link
Member

sdake commented Nov 25, 2019

@yacut Similar in vein to the comments here #546 (comment) I think we should get out of the third party install business and into the third party integration business (via their operators).

Cheers
-steve

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla: yes Set by the Google CLA bot to indicate the author of a PR has signed the Google CLA. ok-to-test Set this label allow normal testing to take place for a PR not submitted by an Istio org member. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants