add persist storage to prometheus

[yacut]

related to istio/istio#18740

[istio-testing]

Hi @yacut. Thanks for your PR.

I'm waiting for a istio member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[morvencao]

/ok-to-test

[istio-testing]

@yacut: The following test failed, say /retest to rerun them all:

Test name	Commit	Details	Rerun command
gencheck_installer	79fbb8d	link	/test gencheck_installer

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[sdake]

@yacut you will need to run make gen with BUILD_WITH_CONTAINERS=1. It may be necessary to unset your HUB and TAG environment variables if they are set (although I believe @howardjohn fixed that problem).

make gen will trigger the generation of binary blobs from the source manifests in the repository.

Cheers
-steve

[sdake]

@howardjohn I am of the opinion that we should punt the third party component install to the upstreams and instead focus on integration with the third-party components. For this specific issue, you had pointed at a path to integration, and @douglas-reid had indicated that path was not going to happen in 1.5 😁

As such, I feel we should just freeze any changes to third party components (unless they involve the resolution of a security vulnerability or general image update) until such time as we can produce an RFC and obtain a sign off or rejection of the RFC from the telemetry WG.

I'll produce the RFC this afternoon.

Cheers
-steve

[johscheuer]

I agree with @sdake also most "production" installations will already have their Prometheus/Grafana installation somehow managed and just putting Istio on top of it (at least in my experience) and the Installer should refer to the official installation docs of the specific tools and just document how to integrate them (or provide some basic dashboards/alerts/..).

One thing that would be interesting would be some kind of a compatibility matrix (I know this can be a lot of work) similar like Istio already states "tested with Kubernetes version X Y Z". The Istio docs could state tested with Tools X Y Z in the following combinations ?

[istio-testing]

@yacut: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[adamrbennett]

@sdake @johscheuer Has an official position been taken with regard to third party components? It sounds like the sentiment here is that out-of-the-box third-party component integration is generally not supported for non-trival use-cases.

[sdake]

@adamrbennett yes a decision has been made for third party components. The decision, as I understand it, is that Istio will provide documentation on istio.io that describes how to integrate with third party components that make sense for Istio to integrate with, assuming there is someone to maintain said integration.

For more context, please review this heavily debated and agreed upon plan and design:

https://docs.google.com/document/d/1jJ4kkALCUPWIlz_Ldu6jpeelMNxyY_SZDMaZmeSpfkM/edit#heading=h.qlmnvhzb2ib2

[sdake]

This PR has been subsumed by https://docs.google.com/document/d/1jJ4kkALCUPWIlz_Ldu6jpeelMNxyY_SZDMaZmeSpfkM/edit#heading=h.qlmnvhzb2ib2. If you disagree, please reopen the issue.

Cheers,
-steve