-
Notifications
You must be signed in to change notification settings - Fork 7.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bump go.mod dependencies #49702
Merged
Merged
bump go.mod dependencies #49702
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
howardjohn
added
the
release-notes-none
Indicates a PR that does not require release notes.
label
Mar 5, 2024
howardjohn
requested review from
a team,
costinm,
linsun,
stevenctl,
ericvn and
hzxuzhonghu
as code owners
March 5, 2024 01:07
istio-testing
added
the
size/L
Denotes a PR that changes 100-499 lines, ignoring generated files.
label
Mar 5, 2024
hzxuzhonghu
reviewed
Mar 5, 2024
@@ -562,7 +562,7 @@ func (s *Server) handleStats(w http.ResponseWriter, r *http.Request) { | |||
format = negotiateMetricsFormat(contentType) | |||
} else { | |||
// Without app metrics format use a default | |||
format = expfmt.FmtText |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why not use it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
they made it private
howardjohn
force-pushed
the
mod/bump-mar-4-2024
branch
from
March 5, 2024 19:58
68fe82b
to
1f27989
Compare
dhawton
reviewed
Mar 5, 2024
istio-testing
added
the
needs-rebase
Indicates a PR needs to be rebased before being merged
label
Mar 5, 2024
hanxiaop
approved these changes
Mar 6, 2024
howardjohn
force-pushed
the
mod/bump-mar-4-2024
branch
from
March 6, 2024 16:24
1f27989
to
f9a7938
Compare
istio-testing
removed
the
needs-rebase
Indicates a PR needs to be rebased before being merged
label
Mar 6, 2024
ericvn
approved these changes
Mar 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
release-notes-none
Indicates a PR that does not require release notes.
size/L
Denotes a PR that changes 100-499 lines, ignoring generated files.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.