zapcore: Ignore nil Entry.Time in encoders #1369
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Codecov Report
@@ Coverage Diff @@
## master #1369 +/- ##
==========================================
+ Coverage 98.28% 98.42% +0.14%
==========================================
Files 53 53
Lines 3493 3493
==========================================
+ Hits 3433 3438 +5
+ Misses 50 46 -4
+ Partials 10 9 -1
... and 1 file with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
abhinav
reviewed
Oct 5, 2023
exp/zapslog/handler_test.go
Outdated
| @@ -189,3 +193,42 @@ func TestAttrKinds(t *testing.T) { | |||
| }, | |||
| entry.ContextMap()) | |||
| } | |||
|
|
|||
| func TestSlogtest(t *testing.T) { | |||
| t.Skip() // TODO: skip for now until test failures are fixed (#1334) | |||
There was a problem hiding this comment.
I would prefer to keep this test off master until we actually have it passing.
t.Skips don't really get follow ups that often—I'd prefer we track the pending work in issues as we're already doing that.
Would you mind deleting this change from this PR?
Comment on lines
+112
to
+114
| { | ||
| desc: "zero_time_omitted", | ||
| expected: `{ |
There was a problem hiding this comment.
Nice. Would you mind adding a similar check to the console_encoder_test.go as well?
This work is being tracked in #1334.
Verifies that the console encoder also skips the time if it's a zero value.
abhinav
approved these changes
Oct 5, 2023
mway
approved these changes
Oct 5, 2023
4 tasks
howardjohn
added a commit
to howardjohn/istio
that referenced
this pull request
Mar 5, 2024
howardjohn
added a commit
to howardjohn/istio
that referenced
this pull request
Mar 5, 2024
howardjohn
added a commit
to howardjohn/istio
that referenced
this pull request
Mar 6, 2024
istio-testing
pushed a commit
to istio/istio
that referenced
this pull request
Mar 6, 2024
* bump go.mod dependencies * jsonpatch evanphx/json-patch#160 * zap uber-go/zap#1369 * lint
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per the comment on
Encoder.EncodeEntry, any fields that are empty including fields on theEntrytype should be omitted. Omit theTimefield when we have empty time.This also aligns with slog.Handler contract.
Refs #1334
Discovered by #1335