disappearing colors on resourcing vimrc in neovim

[nhooyr]

In neovim terminals this happens sometimes only in 'terminal' or 'insert' mode.

Here it is in the same buffer but in normal mode.

No clue what's wrong.

[itchyny]

I cannot reproduce the bug with the following step.
Save the following file as .nvimrc.test

set nocompatible
filetype off
set rtp+=/path/to/lightline.vim
filetype plugin indent on
set laststatus=2

Open neovim with nvim -u .nvimrc.test
Go to insert mode or execute :terminal.

[nhooyr]

I'll try figuring out how to reproduce it. I'm not sure right now.

[nhooyr]

@itchyny figured it out. It has to do with sourcing vimrc again.

https://www.youtube.com/watch?v=y2H0-5H7JVo&feature=youtu.be

I also tested with default vim-airline and it doesn't seem to affect them.

[itchyny]

Please paste the minimal vimrc (which is under 20 lines at most) to reproduce the bug. Otherwise I cannot investigate the reason what causes the bug or even I do not know this is a bug of lightline or of other plugin or of Vim itself.

[nhooyr]

@itchyny were you able to watch the video?

I'll post a vimrc soon just give me a few.

[itchyny]

Yes but I found no clue to reproduce. I close this issue because the issue report is less informative.

[nhooyr]

@itchyny sorry I didn't post the vimrc but did you watch the video?

[itchyny]

Yes

[nhooyr]

@itchyny

filetype off
set rtp+=/usr/local/etc/dotfiles/nvim/plugged/lightline.vim
set rtp+=/usr/local/etc/dotfiles/nvim/plugged/Apprentice
filetype plugin indent on
set laststatus=2
colorscheme apprentice

It only happens if a colorscheme is set (I tried apprentice and solarized etc.)

Steps to reproduce

1. Open neovim with the above as init.vim or use the -u option
2. Open a terminal with :term
3. Now type <c-> to leave terminal mode and then source the init.vim file with :source pathtoinit.vim
4. Now reenter terminal mode by pressing i. Bam the colours should disappear.

[itchyny]

I still cannot reproduce because I don't see what init.vim is.

[nhooyr]

@itchyny in neovim, the ~/.vimrc is called init.vim and its under $XDG_CONFIG_HOME/nvim/init.vim. This is a neovim problem.

[itchyny]

I still cannot reproduce with the following steps.

 $ cat > ./vimrc
filetype off
set rtp+=/path/to/lightline.vim
set rtp+=/path/to/Apprentice
filetype plugin indent on
set laststatus=2
colorscheme apprentice
^D
 $ nvim -u ./vimrc<CR>
:terminal<CR>
^D<CR>
:so ./vimrc<CR>
:terminal<CR>

Am I doing incorrectly?

[itchyny]

Ah, OK. It seems to be appeared on my environment.

[nhooyr]

great. hopefully you can figure out whats going on.

[nhooyr]

@itchyny forgot to reopen the issue, its still closed even though you could reproduce it.

[nhooyr]

@itchyny any updates on this? its still closed even though you managed to reproduce.

[itchyny]

I don't want be bothered by the behaviour which occurs only in neovim, the editor which has different architecture of rendering compared to Vim.

[nhooyr]

@itchyny in that case i'll take a stab and see if I can fix it.

[nhooyr]

@itchyny it has to do with running hi clear in the colorscheme file. This resets the highlighting groups. For some reason lightline then doesn't then reset the terminal highlight groups. Do you know exactly how to fix this?

[nhooyr]

I fixed it, i'll create a PR

[Billy-]

I'm having this issue on Vim 8 on OSX. Is it related? I saw that the PR changed a block that was in has('win32'), so could this fix be applied for osx, too?

[itchyny]

@Billy- Please create a new issue if there's some trouble with environment info, precise steps expected behavior and minimal vimrc if possible.

[Billy-]

I hope I'll be able to find the spare time to do that..