Set highlight groups for terminal mode in lightline#highlight #148
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
How the fix for win64 have something to the issue #144? Is there some reason to fix in one commit? |
|
Also, is there some reason that we should remove |
|
@itchyny i just updated it a bit, now
|
|
I'll add it in a different commit. |
Fixes #144. I just added the missing terminal mode to modes in lightline#highlight() if neovim is being used.
|
@itchyny what do you think now. |
has('win32') includes 64bit windows thus it is pointless to run
has('win64') afterwards.
|
Thank you for your issue report and pull request. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #144.
I just added the missing terminal mode to modes in lightline#highlight() if neovim is being used.
Also has('win32') includes 64bit windows. No need to run has('win64').