Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

term: simplify multiple mentions about dvc.yaml + dvc.lock + .dvc files #1663

Closed
jorgeorpinel opened this issue Aug 6, 2020 · 12 comments
Closed
Labels
A: docs Area: user documentation (gatsby-theme-iterative) p2-nice-to-have Less of a priority at the moment. We don't usually deal with this immediately. status: stale You've been groomed! type: enhancement Something is not clear, small updates, improvement suggestions

Comments

@jorgeorpinel
Copy link
Contributor

jorgeorpinel commented Aug 6, 2020

UPDATE: One thing left here, see #1663 (comment) below.

Continues #1431

Extracted from #1384 (review) et al.

To achieve this, we will probably need to introduce a new glossary term such as "Special DVC files".

@jorgeorpinel jorgeorpinel added A: docs Area: user documentation (gatsby-theme-iterative) p1-important Active priorities to deal within next sprints labels Aug 6, 2020
@shcheklein
Copy link
Member

Not sure about Special though. They are not very special I guess.

@jorgeorpinel
Copy link
Contributor Author

"DVC metafiles"? "DVC-specific files"? Can't use just "DVC files" because it looks almost like ".dvc files".

@shcheklein
Copy link
Member

DVC files with if needed sounds good to me. I don't how to generalize it better. .dvc, dvc.lock, dvc.yaml - they all DVC files, right?

@jorgeorpinel
Copy link
Contributor Author

jorgeorpinel commented Aug 6, 2020

People have always called .dvc files "DVC files", which makes sense and it's one of the reasons we wanted to stop using the term "stage file" (even before 1.0) because we really had to force it and still was not adopted. Throwing in dvc.yaml (and dvc.lock) sounds like making a similar mistake, where we'll have to force people to get that DVC files are not just .dvc files but also other files.

Also, technically theres plenty other "DVC files" such as .dvc/config or plots templates, but we wouldn't include those in the term.

Maybe "stage file" wasn't such a bad term after all...

@jorgeorpinel jorgeorpinel added type: discussion Requires active participation to reach a conclusion. and removed p1-important Active priorities to deal within next sprints labels Aug 7, 2020
@jorgeorpinel jorgeorpinel added the p1-important Active priorities to deal within next sprints label Aug 15, 2020
@jorgeorpinel
Copy link
Contributor Author

OK, so I vote for "DVC metafiles" (would mostly be used in plural). WDYT @shcheklein? Should we call in a vote from everyone via Slack or mentioning them here perhaps?

@jorgeorpinel
Copy link
Contributor Author

jorgeorpinel commented Aug 16, 2020

Actually... a term to group the files may not solve our problems. We also have to repeat the phrase "stages and .dvc files" a lot, and that could not be replaced by a term that refers to files.

We may need a broader concept, kind of like how we used to consider .dvc files "(orphan) stages" before, except I would use that term anymore since it would be overloaded... So maybe "DVC nodes", "DVC blocks"? Idk.

This could be in addition to "DVC (meta)files"

  • DVC node: it can have deps and outs (a possible link in a DAG chain). Includes stages (found in dvc.yaml) and the data structure in .dvc files (the latter has no command thus doesn't represent a process, thus is not a stage).
  • DVC metafile: dvc.yaml files (and corresponding dvc.lock files) and .dvc files. This term refers to special YAML schemas used in DVC.

Although TBH the true solution for all this confusion, I think would start with iterative/dvc#4278.

@shcheklein
Copy link
Member

We may need a broader concept, kind of like how we used to consider .dvc files "(orphan) stages" before, except I would use that term anymore since it would be overloaded... So maybe "DVC nodes", "DVC blocks"? Idk.

sounds too complicated,

We also have to repeat the phrase "stages and .dvc files" a lot, and that could not be replaced by a term that refers to files.

you mean targets? it's mix of everything - path, .dvc. stage names, etc. I guess there is no way to avoid this and it's fine. Also, I would check how other tools solve this.

OK, so I vote for "DVC metafiles"

DVC metafiles is fine.

Should we call in a vote from everyone via Slack or mentioning them here perhaps?

I hope we don't need everyone to vote on this.

@jorgeorpinel
Copy link
Contributor Author

OK. I'm just concerned that the terminology in the core repo will be very different. Terms like DVC-file and stage file are probably still around and even output to users as help messages/ warnings, etc.

@jorgeorpinel jorgeorpinel mentioned this issue Aug 22, 2020
2 tasks
@jorgeorpinel
Copy link
Contributor Author

jorgeorpinel commented Dec 22, 2020

UPDATE on this: we actually went for "DVC Files", already started implementing in #2043 (deployed to https://dvc.org/doc/user-guide/dvc-files).

@jorgeorpinel
Copy link
Contributor Author

  • And after 2.0 docs #2026 is merged, the only thing left (if worth it) will be to decide which instances of longer phrases like "dvc.yaml and .dvc file" to replace for just "DVC Files", and possibly vice versa (be specific in instances of the latter that should for some readon list both or mention only one of the file types).

@jorgeorpinel jorgeorpinel removed the p1-important Active priorities to deal within next sprints label Dec 22, 2020
@jorgeorpinel jorgeorpinel changed the title doc: simplify multiple mentions about dvc.yaml + dvc.lock + .dvc files term: simplify multiple mentions about dvc.yaml + dvc.lock + .dvc files Dec 22, 2020
@jorgeorpinel jorgeorpinel added type: enhancement Something is not clear, small updates, improvement suggestions p2-nice-to-have Less of a priority at the moment. We don't usually deal with this immediately. and removed type: discussion Requires active participation to reach a conclusion. labels Dec 22, 2020
@iesahin iesahin self-assigned this Feb 9, 2021
@iesahin iesahin closed this as completed Feb 9, 2021
@iesahin iesahin reopened this Feb 9, 2021
@iesahin iesahin removed their assignment Feb 21, 2021
@iesahin
Copy link
Contributor

iesahin commented Feb 21, 2021

I'll check this after the merge of #2026.

@jorgeorpinel
Copy link
Contributor Author

jorgeorpinel commented Mar 29, 2022

Closing as probably done (from the comments above). @iesahin feel free to double check if you didn't though. Thanks

@jorgeorpinel jorgeorpinel added the status: stale You've been groomed! label Mar 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A: docs Area: user documentation (gatsby-theme-iterative) p2-nice-to-have Less of a priority at the moment. We don't usually deal with this immediately. status: stale You've been groomed! type: enhancement Something is not clear, small updates, improvement suggestions
Projects
None yet
Development

No branches or pull requests

3 participants